]> git.baikalelectronics.ru Git - kernel.git/commit
i2c: ismt: Fix an out-of-bounds bug in ismt_access()
authorZheyu Ma <zheyuma97@gmail.com>
Fri, 29 Jul 2022 11:02:16 +0000 (19:02 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 18 Jan 2023 10:41:26 +0000 (11:41 +0100)
commitc1c4b3f67fc5192c6e140f5c16f0226728c3bd75
tree3a62df0bea5209420204bb45cfd4169a101109c2
parentfeff5f8b7cf6ffedf88667505c0cb344f7ad1cbf
i2c: ismt: Fix an out-of-bounds bug in ismt_access()

[ Upstream commit 08047e7cc4e6bbc824c01eb296f5f5a8f744d082 ]

When the driver does not check the data from the user, the variable
'data->block[0]' may be very large to cause an out-of-bounds bug.

The following log can reveal it:

[   33.995542] i2c i2c-1: ioctl, cmd=0x720, arg=0x7ffcb3dc3a20
[   33.995978] ismt_smbus 0000:00:05.0: I2C_SMBUS_BLOCK_DATA:  WRITE
[   33.996475] ==================================================================
[   33.996995] BUG: KASAN: out-of-bounds in ismt_access.cold+0x374/0x214b
[   33.997473] Read of size 18446744073709551615 at addr ffff88810efcfdb1 by task ismt_poc/485
[   33.999450] Call Trace:
[   34.001849]  memcpy+0x20/0x60
[   34.002077]  ismt_access.cold+0x374/0x214b
[   34.003382]  __i2c_smbus_xfer+0x44f/0xfb0
[   34.004007]  i2c_smbus_xfer+0x10a/0x390
[   34.004291]  i2cdev_ioctl_smbus+0x2c8/0x710
[   34.005196]  i2cdev_ioctl+0x5ec/0x74c

Fix this bug by checking the size of 'data->block[0]' first.

Fixes: a8a6b2c3d251 ("i2c: Adding support for Intel iSMT SMBus 2.0 host controller")
Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/i2c/busses/i2c-ismt.c