]> git.baikalelectronics.ru Git - kernel.git/commit
bnxt_en: Send HWRM_FUNC_RESET fw command unconditionally.
authorVasundhara Volam <vasundhara-v.volam@broadcom.com>
Mon, 26 Oct 2020 04:18:21 +0000 (00:18 -0400)
committerJakub Kicinski <kuba@kernel.org>
Tue, 27 Oct 2020 01:26:35 +0000 (18:26 -0700)
commitc1ac534c7a8af1a8f5ba61d3d7738b0dc673954f
tree34dc7e52b00833a2547bc53e348af1a0f28637f5
parent4d62291903bd31d44dff241567872d9a20eb3e01
bnxt_en: Send HWRM_FUNC_RESET fw command unconditionally.

In the AER or firmware reset flow, if we are in fatal error state or
if pci_channel_offline() is true, we don't send any commands to the
firmware because the commands will likely not reach the firmware and
most commands don't matter much because the firmware is likely to be
reset imminently.

However, the HWRM_FUNC_RESET command is different and we should always
attempt to send it.  In the AER flow for example, the .slot_reset()
call will trigger this fw command and we need to try to send it to
effect the proper reset.

Fixes: c19773f95ca6 ("bnxt_en: Avoid sending firmware messages when AER error is detected.")
Reviewed-by: Edwin Peer <edwin.peer@broadcom.com>
Signed-off-by: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/broadcom/bnxt/bnxt.c