]> git.baikalelectronics.ru Git - kernel.git/commit
cifs: don't cargo-cult strndup()
authorAl Viro <viro@zeniv.linux.org.uk>
Fri, 5 Mar 2021 20:02:34 +0000 (15:02 -0500)
committerSteve French <stfrench@microsoft.com>
Sun, 25 Apr 2021 21:28:23 +0000 (16:28 -0500)
commitc19e9e940871341c17d13451e3f7f7cdb11f3ef0
treee86654fbc3d834f515bcc97d77f36ae7ba5649d4
parente8e4ca4c0db0f451e7461adecc99fe5384424227
cifs: don't cargo-cult strndup()

strndup(s, strlen(s)) is a highly unidiomatic way to spell strdup(s);
it's *NOT* safer in any way, since strlen() is just as sensitive to
NUL-termination as strdup() is.

strndup() is for situations when you need a copy of a known-sized
substring, not a magic security juju to drive the bad spirits away.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/cifs/cifs_dfs_ref.c
fs/cifs/connect.c
fs/cifs/dfs_cache.c
fs/cifs/fs_context.c
fs/cifs/misc.c
fs/cifs/smb1ops.c
fs/cifs/unc.c