]> git.baikalelectronics.ru Git - kernel.git/commit
net: macb: Increment rx bd head after allocating skb and buffer
authorHarini Katakam <harini.katakam@xilinx.com>
Thu, 12 May 2022 17:19:00 +0000 (22:49 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 25 May 2022 07:57:30 +0000 (09:57 +0200)
commitc166c9ac6a6824cbc526fd6e546c0255163e7936
tree9585423648523280caa60dbf8af24e7cec4bd60e
parent654a76afae01d65de967fa03058d5a99cb2a2bfa
net: macb: Increment rx bd head after allocating skb and buffer

[ Upstream commit 6a0884dca9273b277448dff946be9d0bb882b4b6 ]

In gem_rx_refill rx_prepared_head is incremented at the beginning of
the while loop preparing the skb and data buffers. If the skb or data
buffer allocation fails, this BD will be unusable BDs until the head
loops back to the same BD (and obviously buffer allocation succeeds).
In the unlikely event that there's a string of allocation failures,
there will be an equal number of unusable BDs and an inconsistent RX
BD chain. Hence increment the head at the end of the while loop to be
clean.

Fixes: 573119dbca60 ("net/macb: change RX path for GEM")
Signed-off-by: Harini Katakam <harini.katakam@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Link: https://lore.kernel.org/r/20220512171900.32593-1-harini.katakam@xilinx.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/cadence/macb_main.c