]> git.baikalelectronics.ru Git - kernel.git/commit
vxlan: use the correct nlattr array in NL_SET_ERR_MSG_ATTR
authorSabrina Dubroca <sd@queasysnail.net>
Wed, 22 Apr 2020 15:29:50 +0000 (17:29 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 23 Apr 2020 19:39:09 +0000 (12:39 -0700)
commitc140d7c3e5954689bffdd6b8d4363ff52f559d7d
treeecde45a3e6eeaca368f4c119b61b9847a8bc6005
parenta3729391ec73c950ff82a0deb5ff47b1fc3a3153
vxlan: use the correct nlattr array in NL_SET_ERR_MSG_ATTR

IFLA_VXLAN_* attributes are in the data array, which is correctly
used when fetching the value, but not when setting the extended
ack. Because IFLA_VXLAN_MAX < IFLA_MAX, we avoid out of bounds
array accesses, but we don't provide a pointer to the invalid
attribute to userspace.

Fixes: 23d65c094e4f ("vxlan: change vxlan_[config_]validate() to use netlink_ext_ack for error reporting")
Fixes: 56d9b2aa7ca3 ("vxlan: Allow configuration of DF behaviour")
Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/vxlan.c