]> git.baikalelectronics.ru Git - kernel.git/commit
[PPPOL2TP]: Fix SMP issues in skb reorder queue handling
authorJames Chapman <jchapman@katalix.com>
Thu, 6 Mar 2008 02:40:01 +0000 (18:40 -0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 6 Mar 2008 02:40:01 +0000 (18:40 -0800)
commitc07bcf5e46b58d8e69b53e831b2eebff153b81cf
tree36703dfc6206863464a162f0a4a29a5901314e44
parent9fc2c19386592c5921a997b0c8170cd93c3d4fe3
[PPPOL2TP]: Fix SMP issues in skb reorder queue handling

When walking a session's packet reorder queue, use
skb_queue_walk_safe() since the list could be modified inside the
loop.

Rearrange the unlinking skbs from the reorder queue such that it is
done while the queue lock is held in pppol2tp_recv_dequeue() when
walking the skb list.

A version of this patch was suggested by Jarek Poplawski.

Signed-off-by: James Chapman <jchapman@katalix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/pppol2tp.c