]> git.baikalelectronics.ru Git - kernel.git/commit
net: qcom/emac: fix UAF in emac_remove
authorPavel Skripkin <paskripkin@gmail.com>
Fri, 9 Jul 2021 14:24:18 +0000 (17:24 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 25 Jul 2021 12:35:15 +0000 (14:35 +0200)
commitc071ddc38e53176c8308e2a4ccf17cbe9ca69ddf
tree49664c01bcc7bccb2e6fdad4c22a1bd1eeae8b3d
parentdef8a96c2caaa51718c60d6a464ba8de6a8f58b1
net: qcom/emac: fix UAF in emac_remove

commit ad297cd2db8953e2202970e9504cab247b6c7cb4 upstream.

adpt is netdev private data and it cannot be
used after free_netdev() call. Using adpt after free_netdev()
can cause UAF bug. Fix it by moving free_netdev() at the end of the
function.

Fixes: 7ac30eada592 ("net: qcom/emac: do not use devm on internal phy pdev")
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/qualcomm/emac/emac.c