]> git.baikalelectronics.ru Git - kernel.git/commit
net: dsa: rtl8366rb: Fix off-by-one bug
authorLinus Walleij <linus.walleij@linaro.org>
Sat, 25 Sep 2021 22:59:27 +0000 (00:59 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 27 Sep 2021 15:33:46 +0000 (16:33 +0100)
commitc04627649032257d92d20c85ce6fb55b004746d4
tree985d881b536473a722903b96ca5d2a7c5ebe6e1f
parent38ca17bf997bdb321bfc6df7aaa3d57abd81a4e7
net: dsa: rtl8366rb: Fix off-by-one bug

The max VLAN number with non-4K VLAN activated is 15, and the
range is 0..15. Not 16.

The impact should be low since we by default have 4K VLAN and
thus have 4095 VLANs to play with in this switch. There will
not be a problem unless the code is rewritten to only use
16 VLANs.

Fixes: 397676d73a0a ("net: dsa: realtek-smi: Add Realtek SMI driver")
Cc: Mauri Sandberg <sandberg@mailfence.com>
Cc: DENG Qingfang <dqfext@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Alvin Šipraga <alsi@bang-olufsen.dk>
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/rtl8366rb.c