]> git.baikalelectronics.ru Git - kernel.git/commit
usb: usb251xb: Reallow swap-dx-lanes to apply to the upstream port
authorLucas Stach <l.stach@pengutronix.de>
Fri, 19 Jul 2019 08:44:07 +0000 (10:44 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Jul 2019 09:16:19 +0000 (11:16 +0200)
commitc033e1ece3a3828418662e8c607c9ab072dc6cdc
tree3a5f4065061068cd916d12404a5059abcfd56e93
parent23d7898d71e7ba05bdf5e9aa9d43d4f0b73eb620
usb: usb251xb: Reallow swap-dx-lanes to apply to the upstream port

This is a partial revert of b54bcb57d7c3 "usb: usb251xb: Create a ports
field collector method", which broke a existing devicetree
(arch/arm64/boot/dts/freescale/imx8mq.dtsi).

There is no reason why the swap-dx-lanes property should not apply to
the upstream port. The reason given in the breaking commit was that it's
inconsitent with respect to other port properties, but in fact it is not.
All other properties which only apply to the downstream ports explicitly
reject port 0, so there is pretty strong precedence that the driver
referred to the upstream port as port 0. So there is no inconsistency in
this property at all, other than the swapping being also applicable to
the upstream port.

CC: stable@vger.kernel.org #5.2
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Link: https://lore.kernel.org/r/20190719084407.28041-3-l.stach@pengutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/misc/usb251xb.c