]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: Wedge the GPU if command parser setup fails
authorTvrtko Ursulin <tvrtko.ursulin@intel.com>
Tue, 2 Mar 2021 11:42:13 +0000 (11:42 +0000)
committerDave Airlie <airlied@redhat.com>
Fri, 12 Mar 2021 01:20:50 +0000 (11:20 +1000)
commitc02ff44c8a944b9d14477ea642e79c48132768a7
tree14e3eb176929c23a58ce3aab9728d94bcb3e06e3
parent365ba6442fe837ba86344e3e263d8d840396b441
drm/i915: Wedge the GPU if command parser setup fails

Commit d46d6a4a3438 ("drm/i915: Add support for mandatory cmdparsing")
introduced mandatory command parsing but setup failures were not
translated into wedging the GPU which was probably the intent.

Possible errors come in two categories. Either the sanity check on
internal tables has failed, which should be caught in CI unless an
affected platform would be missed in testing; or memory allocation failure
happened during driver load, which should be extremely unlikely but for
correctness should still be handled.

v2:
 * Tidy coding style. (Chris)

[airlied: cherry-picked to avoid rc1 base]
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Fixes: d46d6a4a3438 ("drm/i915: Add support for mandatory cmdparsing")
Cc: Jon Bloomfield <jon.bloomfield@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Chris Wilson <chris.p.wilson@intel.com>
Reviewed-by: Chris Wilson <chris.p.wilson@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210302114213.1102223-1-tvrtko.ursulin@linux.intel.com
(cherry picked from commit 5a1a659762d35a6dc51047c9127c011303c77b7f)
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
drivers/gpu/drm/i915/gt/intel_engine_cs.c
drivers/gpu/drm/i915/i915_cmd_parser.c
drivers/gpu/drm/i915/i915_drv.h