]> git.baikalelectronics.ru Git - kernel.git/commit
drm: ssd130x: Fix COM scan direction register mask
authorChen-Yu Tsai <wens@csie.org>
Tue, 8 Mar 2022 16:07:57 +0000 (00:07 +0800)
committerJavier Martinez Canillas <javierm@redhat.com>
Wed, 9 Mar 2022 13:55:52 +0000 (14:55 +0100)
commitc02933a94a7ce9b67322cce3f7e388fc43702882
tree0d7546beeaf93720257cf6367171d3bb85fd8ab6
parentcd9f33ce24a601e977cc929b70ca47aecb9e2e4f
drm: ssd130x: Fix COM scan direction register mask

The SSD130x's command to toggle COM scan direction uses bit 3 and only
bit 3 to set the direction of the scanout. The driver has an incorrect
GENMASK(3, 2), causing the setting to be set on bit 2, rendering it
ineffective.

Fix the mask to only bit 3, so that the requested setting is applied
correctly.

Fixes: 8bab3f281293 ("drm: Add driver for Solomon SSD130x OLED displays")
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Acked-by: Javier Martinez Canillas <javierm@redhat.com>
Tested-by: Geert Uytterhoeven <geert@linux-m68k.org>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220308160758.26060-1-wens@kernel.org
drivers/gpu/drm/solomon/ssd130x.c