]> git.baikalelectronics.ru Git - kernel.git/commit
mptcp: stop using the mptcp_has_another_subflow() helper
authorPaolo Abeni <pabeni@redhat.com>
Wed, 18 May 2022 22:04:43 +0000 (15:04 -0700)
committerJakub Kicinski <kuba@kernel.org>
Fri, 20 May 2022 03:05:07 +0000 (20:05 -0700)
commitbfca3f7e95387d3b54980614a51adf93f695e0bc
treea73694f2b3e93e1ee118947a810145744f889a48
parent0da6ab350a2e9b23d3ffcd18a5ce010cea5dcd0e
mptcp: stop using the mptcp_has_another_subflow() helper

The mentioned helper requires the msk socket lock, and the
current callers don't own it nor can't acquire it, so the
access is racy.

All the current callers are really checking for infinite mapping
fallback, and the latter condition is explicitly tracked by
the relevant msk variable: we can safely remove the caller usage
- and the caller itself.

The issue is present since MP_FAIL implementation, but the
fix only applies since the infinite fallback support, ence the
somewhat unexpected fixes tag.

Fixes: dfff41b8d772 ("mptcp: track and update contiguous data status")
Acked-and-tested-by: Geliang Tang <geliang.tang@suse.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/mptcp/pm.c
net/mptcp/protocol.h
net/mptcp/subflow.c