]> git.baikalelectronics.ru Git - kernel.git/commit
xfs: calculate correct offset in xfs_scrub_quota_item
authorEric Sandeen <sandeen@redhat.com>
Tue, 28 Nov 2017 02:23:33 +0000 (18:23 -0800)
committerDarrick J. Wong <darrick.wong@oracle.com>
Tue, 28 Nov 2017 16:57:11 +0000 (08:57 -0800)
commitbef1054113e40909ac7496ad2823e1ddaace5771
treeccf0021f560ed2c56c6d91b99f662c2792aa4445
parent53fd8e4f57fea0034b5a706ee87bb4132d542916
xfs: calculate correct offset in xfs_scrub_quota_item

It's only used for tracepoints so it's relatively harmless,
but the offset is calculated incorrectly in xfs_scrub_quota_item.

qi_dqperchunk is the nr. of dquots per "chunk" which we have
conveniently *cough* defined to always be 1 FSB.  Therefore
block_offset * qi_dqperchunk == first id in that chunk,
and so offset = id / qi_dqperchunk

id * dqperchunk is ... meaningless.

Fixes-coverity-id: 1423965
Fixes: f44d0b88 ("xfs: scrub quota information")
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
fs/xfs/scrub/quota.c