]> git.baikalelectronics.ru Git - kernel.git/commit
mm/khugepaged: invoke MMU notifiers in shmem/file collapse paths
authorJann Horn <jannh@google.com>
Tue, 6 Dec 2022 17:16:10 +0000 (18:16 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Dec 2022 10:30:42 +0000 (11:30 +0100)
commitbeadf458022753c6a15a22e5e4423d1f02ffc04d
tree6eaaad07864ef97019d888a8e060ae00696e46fd
parent4e4751639400ac2832f93a5825b2160cda20f0de
mm/khugepaged: invoke MMU notifiers in shmem/file collapse paths

commit 41c9e05a531f93dc9d2471152b7c5e419d0ad7d9 upstream.

Any codepath that zaps page table entries must invoke MMU notifiers to
ensure that secondary MMUs (like KVM) don't keep accessing pages which
aren't mapped anymore.  Secondary MMUs don't hold their own references to
pages that are mirrored over, so failing to notify them can lead to page
use-after-free.

I'm marking this as addressing an issue introduced in commit eb3c2950d686
("khugepaged: add support of collapse for tmpfs/shmem pages"), but most of
the security impact of this only came in commit 9ded1373a615 ("khugepaged:
enable collapse pmd for pte-mapped THP"), which actually omitted flushes
for the removal of present PTEs, not just for the removal of empty page
tables.

Link: https://lkml.kernel.org/r/20221129154730.2274278-3-jannh@google.com
Link: https://lkml.kernel.org/r/20221128180252.1684965-3-jannh@google.com
Link: https://lkml.kernel.org/r/20221125213714.4115729-3-jannh@google.com
Fixes: eb3c2950d686 ("khugepaged: add support of collapse for tmpfs/shmem pages")
Signed-off-by: Jann Horn <jannh@google.com>
Acked-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Yang Shi <shy828301@gmail.com>
Cc: John Hubbard <jhubbard@nvidia.com>
Cc: Peter Xu <peterx@redhat.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
[manual backport: this code was refactored from two copies into a common
helper between 5.15 and 6.0]
Signed-off-by: Jann Horn <jannh@google.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
mm/khugepaged.c