]> git.baikalelectronics.ru Git - kernel.git/commit
s390/qdio: clarify handler logic for qdio_handle_activate_check()
authorJulian Wiedmann <jwi@linux.ibm.com>
Mon, 15 Nov 2021 07:28:08 +0000 (08:28 +0100)
committerHeiko Carstens <hca@linux.ibm.com>
Mon, 6 Dec 2021 13:42:25 +0000 (14:42 +0100)
commitbe905f37706f1d03d41351aa8c567c11d0ecc373
tree559e401288d20c6c043dd97760b77499bc1cab3e
parentf915174f56881fa257f626e9389fb1908e9f8665
s390/qdio: clarify handler logic for qdio_handle_activate_check()

qdio_handle_activate_check() tries to re-use one of the queue-specific
handlers to report that the ACTIVATE ccw has been terminated. But the
logic to select that handler is overly complex - in practice both
qdio drivers have at least one Input Queue, so we never take the other
paths.

Make things more obvious by removing this unused code, and clearly
spelling out that we re-use the Input Handler for generic error
reporting. This also paves the way for a world without queue-specific
error handlers.

Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Reviewed-by: Benjamin Block <bblock@linux.ibm.com>
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
arch/s390/include/asm/qdio.h
drivers/s390/cio/qdio.h
drivers/s390/cio/qdio_main.c
drivers/s390/cio/qdio_setup.c