]> git.baikalelectronics.ru Git - kernel.git/commit
[media] gpio-ir-recv: a couple signedness bugs
authorDan Carpenter <dan.carpenter@oracle.com>
Sat, 10 Mar 2012 07:58:18 +0000 (04:58 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Mon, 19 Mar 2012 18:45:01 +0000 (15:45 -0300)
commitbdefb5958a2665624762c135a3c66505da2c28f1
treef0046ed726b7c677d6d70d256c816573cb503932
parente46358d17fd73d2d390506ebab2f6cecb6cd2548
[media] gpio-ir-recv: a couple signedness bugs

There are couple places where we check unsigned values for negative.  I
changed ->gpin_nr to signed because in gpio_ir_recv_probe() we do:
        if (pdata->gpio_nr < 0)
                return -EINVAL;
I also change gval to a signed int in gpio_ir_recv_irq() because that's
the type that gpio_get_value_cansleep() returns and we test for negative
returns.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Trilok Soni <tsoni@codeaurora.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/rc/gpio-ir-recv.c
include/media/gpio-ir-recv.h