]> git.baikalelectronics.ru Git - kernel.git/commit
btrfs: fix lzo_decompress_bio() kmap leakage
authorLinus Torvalds <torvalds@linux-foundation.org>
Mon, 1 Nov 2021 19:46:47 +0000 (12:46 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Mon, 1 Nov 2021 19:46:47 +0000 (12:46 -0700)
commitbd804fb18f2e2408eb8ecc7c8923cbc8c5dd1bf9
treed6f1220aa79dad8d9a15362ef47ab23b34c07c0b
parentab47afc32b23167b4d60ef9cc36fc23b493190c9
btrfs: fix lzo_decompress_bio() kmap leakage

Commit 6103c1cc8a52 reinstated the kmap/kunmap that had been dropped in
commit a5a53b133aa5 ("btrfs: compression: drop kmap/kunmap from lzo").

However, it seems to have done so incorrectly due to the change not
reverting cleanly, and lzo_decompress_bio() ended up not having a
matching "kunmap()" to the "kmap()" that was put back.

Also, any assert that the page pointer is not NULL should be before the
kmap() of said pointer, since otherwise you'd just oops in the kmap()
before the assert would even trigger.

I noticed this when trying to verify my btrfs merge, and things not
adding up.  I'm doing this fixup before re-doing my merge, because this
commit needs to also be backported to 5.15 (after verification from the
btrfs people).

Fixes: 6103c1cc8a52 ("Revert 'btrfs: compression: drop kmap/kunmap from lzo'")
Cc: David Sterba <dsterba@suse.com>
Cc: stable@kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/btrfs/lzo.c