]> git.baikalelectronics.ru Git - kernel.git/commit
drm/fb-helper: kill drm_fb_helper_restore
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Sun, 20 Jan 2013 17:09:52 +0000 (18:09 +0100)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 13 Feb 2013 23:07:50 +0000 (00:07 +0100)
commitbd1dd6d6c34f02f00a2af90762b216f87359b680
treef819eb34fd3f32ae79cca5421e6c688ed3d6f928
parenta9b5fb6dc15a0f421a0deb2c1d662e16b6cfbfea
drm/fb-helper: kill drm_fb_helper_restore

It's only used internally for the sysrq and panic handlers provided by
the drm fb helper implementation. Hence just inline it, kill the
export and remove the confusing kerneldoc. Driver's are supposed to
call drm_fb_helper_restore_fbdev_mode on lastclose.

Note that locking is totally fubar - the sysrq case doesn't take any
locks at all. The panic handler probably shouldn't take any locks
since it'll only make things worse. Otoh it's probably better to
switch things over to the atomic modeset callbacks (and disable the
panic handler for those drivers which don't implement it).

But that's both better done in separate patches.

Reviewed-by: Rob Clark <robdclark@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/drm_fb_helper.c
include/drm/drm_fb_helper.h