]> git.baikalelectronics.ru Git - kernel.git/commit
bdi: wake up concurrent wb_shutdown() callers.
authorTetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Tue, 1 May 2018 22:07:55 +0000 (07:07 +0900)
committerJens Axboe <axboe@kernel.dk>
Thu, 3 May 2018 15:25:47 +0000 (09:25 -0600)
commitbc86b9986c16716acdb0d9908f4ab98b90bbcfd1
treeb991aa5f1bea88908b05338a24f7db6c0f09fa2d
parente565804b5a770844367dad95414b03c9c2422d8d
bdi: wake up concurrent wb_shutdown() callers.

syzbot is reporting hung tasks at wait_on_bit(WB_shutting_down) in
wb_shutdown() [1]. This seems to be because commit e43bd708de3f90da ("bdi:
Shutdown writeback on all cgwbs in cgwb_bdi_destroy()") forgot to call
wake_up_bit(WB_shutting_down) after clear_bit(WB_shutting_down).

Introduce a helper function clear_and_wake_up_bit() and use it, in order
to avoid similar errors in future.

[1] https://syzkaller.appspot.com/bug?id=b297474817af98d5796bc544e1bb806fc3da0e5e

Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Reported-by: syzbot <syzbot+c0cf869505e03bdf1a24@syzkaller.appspotmail.com>
Fixes: e43bd708de3f90da ("bdi: Shutdown writeback on all cgwbs in cgwb_bdi_destroy()")
Cc: Tejun Heo <tj@kernel.org>
Reviewed-by: Jan Kara <jack@suse.cz>
Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
include/linux/wait_bit.h
mm/backing-dev.c