]> git.baikalelectronics.ru Git - kernel.git/commit
firmware: cs_dsp: Fix new control name check
authorVlad Karpovich <vkarpovi@opensource.cirrus.com>
Tue, 15 Aug 2023 17:29:08 +0000 (12:29 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 13 Sep 2023 07:42:44 +0000 (09:42 +0200)
commitbc82cd1e7ff28e35b144c73bbc9af2fbfd1ab540
tree4f18b70d60c0225f95ab1d2423d93e85466e87f6
parent711fb92606208a8626b785da4f9f23d648a5b6c8
firmware: cs_dsp: Fix new control name check

[ Upstream commit 7ac1102b227b36550452b663fd39ab1c09378a95 ]

Before adding a new FW control, its name is checked against
existing controls list. But the string length in strncmp used
to compare controls names is taken from the list, so if beginnings
of the controls are matching,  then the new control is not created.
For example, if CAL_R control already exists, CAL_R_SELECTED
is not created.
The fix is to compare string lengths as well.

Fixes: 6477960755fb ("ASoC: wm_adsp: Move check for control existence")
Signed-off-by: Vlad Karpovich <vkarpovi@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20230815172908.3454056-1-vkarpovi@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/firmware/cirrus/cs_dsp.c