]> git.baikalelectronics.ru Git - kernel.git/commit
ubi: Fix UAF wear-leveling entry in eraseblk_count_seq_show()
authorZhihao Cheng <chengzhihao1@huawei.com>
Sat, 30 Jul 2022 11:28:37 +0000 (19:28 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 11 Mar 2023 12:55:21 +0000 (13:55 +0100)
commitbbb83f0d414eeee9b605df1fd779273c4ab804ee
tree2983b115057f74a8808d5cbdc408f68a258dc762
parentbcc1afebf5c00c18769a7f4b0576f260246c900f
ubi: Fix UAF wear-leveling entry in eraseblk_count_seq_show()

[ Upstream commit a323417b30373f2222d80d3f13c069b29a782d92 ]

Wear-leveling entry could be freed in error path, which may be accessed
again in eraseblk_count_seq_show(), for example:

__erase_worker                eraseblk_count_seq_show
                                wl = ubi->lookuptbl[*block_number]
if (wl)
  wl_entry_destroy
    ubi->lookuptbl[e->pnum] = NULL
    kmem_cache_free(ubi_wl_entry_slab, e)
                   erase_count = wl->ec  // UAF!

Wear-leveling entry updating/accessing in ubi->lookuptbl should be
protected by ubi->wl_lock, fix it by adding ubi->wl_lock to serialize
wl entry accessing between wl_entry_destroy() and
eraseblk_count_seq_show().

Fetch a reproducer in [Link].

Link: https://bugzilla.kernel.org/show_bug.cgi?id=216305
Fixes: e0d3bf009282c9 ("ubi: Add debugfs file for tracking PEB state")
Fixes: 8170740f4ed1a5 ("UBI: Unsorted Block Images")
Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/mtd/ubi/wl.c