]> git.baikalelectronics.ru Git - kernel.git/commit
net: wwan: iosm: remove pointless null check
authorJakub Kicinski <kuba@kernel.org>
Thu, 19 May 2022 00:43:42 +0000 (17:43 -0700)
committerJakub Kicinski <kuba@kernel.org>
Fri, 20 May 2022 01:44:44 +0000 (18:44 -0700)
commitbbaf00048efa9d8d1c24177f25abd8bf5ee08bf8
treeec16c32e9842de9a2c8e319b8fdfa4610cccdd90
parent51e523cdb71f69e9c8d3de1a66ff1f10012988da
net: wwan: iosm: remove pointless null check

GCC 12 warns:

drivers/net/wwan/iosm/iosm_ipc_protocol_ops.c: In function ‘ipc_protocol_dl_td_process’:
drivers/net/wwan/iosm/iosm_ipc_protocol_ops.c:406:13: warning: the comparison will always evaluate as ‘true’ for the address of ‘cb’ will never be NULL [-Waddress]
  406 |         if (!IPC_CB(skb)) {
      |             ^

Indeed the check seems entirely pointless. Hopefully the other
validation checks will catch if the cb is bad, but it can't be
NULL.

Reviewed-by: M Chetan Kumar <m.chetan.kumar@intel.com>
Link: https://lore.kernel.org/r/20220519004342.2109832-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/wwan/iosm/iosm_ipc_protocol_ops.c