]> git.baikalelectronics.ru Git - kernel.git/commit
ethtool: fix reference leak in ethnl_set_privflags()
authorMichal Kubecek <mkubecek@suse.cz>
Fri, 27 Mar 2020 23:01:03 +0000 (00:01 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 30 Mar 2020 05:32:36 +0000 (22:32 -0700)
commitbba9990c33a5fa65ac292c14c305048081e2ad09
treebd9cd9d74a74ceafcc577577ca1178f2e7cac16e
parent9fbed51cf0dc4f9a8a1868072df740eec9fff9f5
ethtool: fix reference leak in ethnl_set_privflags()

Andrew noticed that some handlers for *_SET commands leak a netdev
reference if required ethtool_ops callbacks do not exist. One of them is
ethnl_set_privflags(), a simple reproducer would be e.g.

  ip link add veth1 type veth peer name veth2
  ethtool --set-priv-flags veth1 foo on
  ip link del veth1

Make sure dev_put() is called when ethtool_ops check fails.

Fixes: 7f26a92e285c ("ethtool: set device private flags with PRIVFLAGS_SET request")
Reported-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ethtool/privflags.c