]> git.baikalelectronics.ru Git - kernel.git/commit
nvme-pci: Hold cq_poll_lock while completing CQEs
authorBijan Mottahedeh <bijan.mottahedeh@oracle.com>
Thu, 27 Feb 2020 02:53:43 +0000 (18:53 -0800)
committerKeith Busch <kbusch@kernel.org>
Thu, 27 Feb 2020 16:32:14 +0000 (01:32 +0900)
commitbb8f0daaad628e6479a24651de6c9a99ac6103c4
treeabe811e8684f25b41397639a2c41b54466bbc8a1
parent2dbb2b01049c2c1ccce08086a49b932513a3b59b
nvme-pci: Hold cq_poll_lock while completing CQEs

Completions need to consumed in the same order the controller submitted
them, otherwise future completion entries may overwrite ones we haven't
handled yet. Hold the nvme queue's poll lock while completing new CQEs to
prevent another thread from freeing command tags for reuse out-of-order.

Fixes: 023960f4c905 ("nvme: provide optimized poll function for separate poll queues")
Signed-off-by: Bijan Mottahedeh <bijan.mottahedeh@oracle.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Keith Busch <kbusch@kernel.org>
drivers/nvme/host/pci.c