]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "Revert "block, bfq: honor already-setup queue merges""
authorPaolo Valente <paolo.valente@linaro.org>
Thu, 25 Nov 2021 18:15:10 +0000 (19:15 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 8 Apr 2022 12:23:56 +0000 (14:23 +0200)
commitbb8e283f1ca0138bc29a5221d3755480addc8c70
tree03fc27d431d5bd3bfe2755dc2f353ac49760df10
parent3be6042a1443578a82f79447b6595af2e426f9b9
Revert "Revert "block, bfq: honor already-setup queue merges""

[ Upstream commit 13c568efdb9388996dfcb1b5d6bc9b489d0a7139 ]

A crash [1] happened to be triggered in conjunction with commit
fde25220c9a5 ("block, bfq: honor already-setup queue merges"). The
latter was then reverted by commit 6dad861d8d68 ("Revert "block, bfq:
honor already-setup queue merges""). Yet, the reverted commit was not
the one introducing the bug. In fact, it actually triggered a UAF
introduced by a different commit, and now fixed by commit 87b280b3944d
("block, bfq: reset last_bfqq_created on group change").

So, there is no point in keeping commit fde25220c9a5 ("block, bfq:
honor already-setup queue merges") out. This commit restores it.

[1] https://bugzilla.kernel.org/show_bug.cgi?id=214503

Reported-by: Holger Hoffstätte <holger@applied-asynchrony.com>
Signed-off-by: Paolo Valente <paolo.valente@linaro.org>
Link: https://lore.kernel.org/r/20211125181510.15004-1-paolo.valente@linaro.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
block/bfq-iosched.c