]> git.baikalelectronics.ru Git - kernel.git/commit
i8k: Fix non-SMP operation
authorGuenter Roeck <linux@roeck-us.net>
Sat, 21 Jun 2014 15:08:08 +0000 (08:08 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 9 Jul 2014 23:45:36 +0000 (16:45 -0700)
commitbb66d94d130ba27fdef42412f42d52889d1143fe
treea9f92ac3d796ca010b7d9bcb7c1b5d8a0ef8da3f
parentb93344ad252e6eac29abd55ccf89ca95fdca8850
i8k: Fix non-SMP operation

Commit ec0f9333b7bf (i8k: Force SMM to run on CPU 0) adds support
for multi-core CPUs to the driver. Unfortunately, that causes it
to fail loading if compiled without SMP support, at least on
32 bit kernels. Kernel log shows "i8k: unable to get SMM Dell
signature", and function i8k_smm is found to return -EINVAL.

Testing revealed that the culprit is the missing return value check
of set_cpus_allowed_ptr.

Fixes: ec0f9333b7bf (i8k: Force SMM to run on CPU 0)
Reported-by: Jim Bos <jim876@xs4all.nl>
Tested-by: Jim Bos <jim876@xs4all.nl>
Cc: stable@vger.kernel.org # 3.14+
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Cc: Andreas Mohr <andi@lisas.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/char/i8k.c