]> git.baikalelectronics.ru Git - kernel.git/commit
tty: n_gsm: fix wrong T1 retry count handling
authorDaniel Starke <daniel.starke@siemens.com>
Thu, 7 Jul 2022 11:32:20 +0000 (13:32 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Aug 2022 09:18:03 +0000 (11:18 +0200)
commitbb3175eab620cdf89ba9eb568910892c5dfca419
tree1e26742c94a71ccffd476dd59b697299a8001142
parent6a5198d982100b430fd44885894817169214d952
tty: n_gsm: fix wrong T1 retry count handling

[ Upstream commit db7e8e91b88759710ea35fe7d526ce078bc4afef ]

n_gsm is based on the 3GPP 07.010 and its newer version is the 3GPP 27.010.
See https://portal.3gpp.org/desktopmodules/Specifications/SpecificationDetails.aspx?specificationId=1516
The changes from 07.010 to 27.010 are non-functional. Therefore, I refer to
the newer 27.010 here. Chapter 5.7.3 states that the valid range for the
maximum number of retransmissions (N2) is from 0 to 255 (both including).
gsm_dlci_t1() handles this number incorrectly by performing N2 - 1
retransmission attempts. Setting N2 to zero results in more than 255
retransmission attempts.
Fix gsm_dlci_t1() to comply with 3GPP 27.010.

Fixes: 99551fa31543 ("tty: n_gsm line discipline")
Signed-off-by: Daniel Starke <daniel.starke@siemens.com>
Link: https://lore.kernel.org/r/20220707113223.3685-1-daniel.starke@siemens.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/tty/n_gsm.c