]> git.baikalelectronics.ru Git - kernel.git/commit
nsdeps: make generated patches independent of locale
authorMasahiro Yamada <yamada.masahiro@socionext.com>
Thu, 3 Oct 2019 07:58:26 +0000 (16:58 +0900)
committerJessica Yu <jeyu@kernel.org>
Mon, 7 Oct 2019 16:25:29 +0000 (18:25 +0200)
commitbb0b15f5edbafd9bf3728a7b5209fb4c6943110f
tree83ba1386a64f57f06a8764b25d43b7a309a794a5
parenteffc40cc44908f325252539d87642270aa961d2e
nsdeps: make generated patches independent of locale

scripts/nsdeps automatically generates a patch to add MODULE_IMPORT_NS
tags, and what is nicer, it sorts the lines alphabetically with the
'sort' command. However, the output from the 'sort' command depends on
locale.

For example, I got this:

$ { echo usbstorage; echo usb_storage; } | LANG=en_US.UTF-8 sort
usbstorage
usb_storage
$ { echo usbstorage; echo usb_storage; } | LANG=C sort
usb_storage
usbstorage

So, this means people might potentially send different patches.

This kind of issue was reported in the past, for example,
commit da5f819828b9 ("kbuild: make sorting initramfs contents
independent of locale").

Adding 'LANG=C' is a conventional way of fixing when a deterministic
result is desirable.

I added 'LANG=C' very close to the 'sort' command since changing
locale affects the language of error messages etc. We should respect
users' choice as much as possible.

Reviewed-by: Matthias Maennich <maennich@google.com>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Signed-off-by: Jessica Yu <jeyu@kernel.org>
scripts/nsdeps