]> git.baikalelectronics.ru Git - kernel.git/commit
iavf: fix double unlock of crit_lock
authorStefan Assmann <sassmann@kpanic.de>
Tue, 24 Aug 2021 10:06:39 +0000 (12:06 +0200)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Wed, 6 Oct 2021 16:49:34 +0000 (09:49 -0700)
commitba22ad5a6bff409079225008d32b2dd95f7ef9e4
tree93db707f465fba18bf00fb527ab47bdeb5371be3
parentd718948b2408513002e25c7c9b7c3f04ba83ce42
iavf: fix double unlock of crit_lock

The crit_lock mutex could be unlocked twice as reported here
https://lists.osuosl.org/pipermail/intel-wired-lan/Week-of-Mon-20210823/025525.html

Remove the superfluous unlock. Technically the problem was already
present before 3e0a61a5b57d as that commit only replaced the locking
primitive, but no functional change.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 3e0a61a5b57d ("iavf: use mutexes for locking of critical sections")
Fixes: 174bee62d924 ("iavf: Refactor the watchdog state machine")
Signed-off-by: Stefan Assmann <sassmann@kpanic.de>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/iavf/iavf_main.c