]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: firewire-tascam: check intermediate state of clock status and retry
authorTakashi Sakamoto <o-takashi@sakamocchi.jp>
Tue, 10 Sep 2019 13:51:52 +0000 (22:51 +0900)
committerTakashi Iwai <tiwai@suse.de>
Tue, 10 Sep 2019 14:16:46 +0000 (16:16 +0200)
commitb9a8291a040e6c51b6de0bc8fea6f41ef30b37f5
tree160710c7527cbd1e503560557936aa82b1804046
parentaf5fe26cab28d3d6a676337ec74390b754652f61
ALSA: firewire-tascam: check intermediate state of clock status and retry

2 bytes in MSB of register for clock status is zero during intermediate
state after changing status of sampling clock in models of TASCAM FireWire
series. The duration of this state differs depending on cases. During the
state, it's better to retry reading the register for current status of
the clock.

In current implementation, the intermediate state is checked only when
getting current sampling transmission frequency, then retry reading.
This care is required for the other operations to read the register.

This commit moves the codes of check and retry into helper function
commonly used for operations to read the register.

Fixes: 624b89df2fd7 ("ALSA: firewire-tascam: add PCM functionality")
Cc: <stable@vger.kernel.org> # v4.4+
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://lore.kernel.org/r/20190910135152.29800-3-o-takashi@sakamocchi.jp
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/firewire/tascam/tascam-stream.c