]> git.baikalelectronics.ru Git - kernel.git/commit
iio:chemical:bme680: Fix SPI read interface
authorMike Looijmans <mike.looijmans@topic.nl>
Wed, 6 Mar 2019 07:31:48 +0000 (08:31 +0100)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sat, 9 Mar 2019 17:27:36 +0000 (17:27 +0000)
commitb979b78c5f02b8f8317b9a1940ac7923a685e9dd
tree07eaf7b76e7fac992b698b987ccf60cbba3f1f1b
parentd9d101aeb08b7746717d875924f15a859542f6cc
iio:chemical:bme680: Fix SPI read interface

The SPI interface implementation was completely broken.

When using the SPI interface, there are only 7 address bits, the upper bit
is controlled by a page select register. The core needs access to both
ranges, so implement register read/write for both regions. The regmap
paging functionality didn't agree with a register that needs to be read
and modified, so I implemented a custom paging algorithm.

This fixes that the device wouldn't even probe in SPI mode.

The SPI interface then isn't different from I2C, merged them into the core,
and the I2C/SPI named registers are no longer needed.

Implemented register value caching for the registers to reduce the I2C/SPI
data transfers considerably.

The calibration set reads as all zeroes until some undefined point in time,
and I couldn't determine what makes it valid. The datasheet mentions these
registers but does not provide any hints on when they become valid, and they
aren't even enumerated in the memory map. So check the calibration and
retry reading it from the device after each measurement until it provides
something valid.

Despite the size this is suitable for a stable backport given that
it seems the SPI support never worked.

Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
Fixes: f46919e08425 ("iio: chemical: Add support for Bosch BME680 sensor");
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/chemical/bme680.h
drivers/iio/chemical/bme680_core.c
drivers/iio/chemical/bme680_i2c.c
drivers/iio/chemical/bme680_spi.c