]> git.baikalelectronics.ru Git - kernel.git/commit
hwmon: (dell-smm) Reword and mark parameter "force" as unsafe
authorArmin Wolf <W_Armin@gmx.de>
Tue, 15 Feb 2022 19:11:13 +0000 (20:11 +0100)
committerGuenter Roeck <linux@roeck-us.net>
Mon, 28 Feb 2022 01:03:19 +0000 (17:03 -0800)
commitb957525fc387b721910827689610702ea1ce1ed0
tree2356fa330f5d2ca664ad3252989ff9f0f493ce65
parent9b5c9e0e3ee4ad4cf92480a2286d43ccbd95eaeb
hwmon: (dell-smm) Reword and mark parameter "force" as unsafe

When enabling said module parameter, the driver ignores
all feature blacklists on relevant models, which has the
potential for strange side effects. Also there seems to
be a slight chance for unsupported devices to behave
badly when probed for features.
In such cases, the kernel should be tainted to inform
people that these issues might have been caused by
the dell_smm_hwmon driver with "force" enabled.
Also reword the parameter description to remind users
that enabling "force" also enables blacklisted features.

Tested on a Dell Inspiron 3505.

Signed-off-by: Armin Wolf <W_Armin@gmx.de>
Reviewed-by: Pali Rohár <pali@kernel.org>
Link: https://lore.kernel.org/r/20220215191113.16640-8-W_Armin@gmx.de
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/dell-smm-hwmon.c