]> git.baikalelectronics.ru Git - kernel.git/commit
net: stmmac: fix failed to suspend if phy based WOL is enabled
authorJisheng Zhang <Jisheng.Zhang@synaptics.com>
Mon, 3 Aug 2020 08:56:47 +0000 (16:56 +0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 4 Aug 2020 00:59:39 +0000 (17:59 -0700)
commitb9146ca0d2b0711dc45a9fef4fa95a93b4ea331e
tree59ad6c7e51efd6569cd4e111a7dd864c19012444
parent0c142e2798fafdeb1986512dc9c6a36e39006b17
net: stmmac: fix failed to suspend if phy based WOL is enabled

With the latest net-next tree, if test suspend/resume after enabling
WOL, we get error as below:

[  487.086365] dpm_run_callback(): mdio_bus_suspend+0x0/0x30 returns -16
[  487.086375] PM: Device stmmac-0:00 failed to suspend: error -16

-16 means -EBUSY, this is because I didn't enable wakeup of the correct
device when implementing phy based WOL feature. To be honest, I caught
the issue when implementing phy based WOL and then fix it locally, but
forgot to amend the phy based wol patch. Today, I found the issue by
testing net-next tree.

Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c