]> git.baikalelectronics.ru Git - kernel.git/commit
can: mcba_usb: mcba_usb_start_xmit(): fix double dev_kfree_skb in error path
authorHangyu Hua <hbh25y@gmail.com>
Fri, 11 Mar 2022 08:02:08 +0000 (16:02 +0800)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Thu, 31 Mar 2022 07:55:27 +0000 (09:55 +0200)
commitb83f14f22abedfe35f5c3a8b1283a3fa10dfd99d
treec0a0c04bbd11c20e6b40870bcbeafd91a9b76493
parent5944fa715996ec401c5f30c861e97c31b7d60489
can: mcba_usb: mcba_usb_start_xmit(): fix double dev_kfree_skb in error path

There is no need to call dev_kfree_skb() when usb_submit_urb() fails
because can_put_echo_skb() deletes original skb and
can_free_echo_skb() deletes the cloned skb.

Fixes: 3405f1d6e64b ("can: mcba_usb: Add support for Microchip CAN BUS Analyzer")
Link: https://lore.kernel.org/all/20220311080208.45047-1-hbh25y@gmail.com
Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/usb/mcba_usb.c