]> git.baikalelectronics.ru Git - kernel.git/commit
net: sparx5: fix error handling in sparx5_port_open()
authorLiu Jian <liujian56@huawei.com>
Thu, 17 Nov 2022 12:59:18 +0000 (20:59 +0800)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 22 Nov 2022 10:41:49 +0000 (11:41 +0100)
commitb8393b1f12837f11be6e97532edb24edcca2e21a
treed115d757c937a6adf6adb3657c5c6c7ebeb04fbb
parent9e67ce85563d25c581e536581dba18c03910e4fe
net: sparx5: fix error handling in sparx5_port_open()

If phylink_of_phy_connect() fails, the port should be disabled.
If sparx5_serdes_set()/phy_power_on() fails, the port should be
disabled and the phylink should be stopped and disconnected.

Fixes: fccc10d02ce0 ("net: sparx5: add port module support")
Fixes: 84762eac925f ("net: sparx5: add hostmode with phylink support")
Signed-off-by: Liu Jian <liujian56@huawei.com>
Tested-by: Bjarni Jonasson <bjarni.jonasson@microchip.com>
Reviewed-by: Steen Hegelund <steen.hegelund@microchip.com>
Link: https://lore.kernel.org/r/20221117125918.203997-1-liujian56@huawei.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/microchip/sparx5/sparx5_netdev.c