]> git.baikalelectronics.ru Git - kernel.git/commit
EDAC/dmc520: Don't print an error for each unconfigured interrupt line
authorTyler Hicks <tyhicks@linux.microsoft.com>
Tue, 11 Jan 2022 16:38:00 +0000 (10:38 -0600)
committerBorislav Petkov <bp@suse.de>
Tue, 19 Apr 2022 09:25:41 +0000 (11:25 +0200)
commitb812e58818592db59a429c8546b00f91de637bff
tree40cca5b6eed8255f0f0313a0faf1713d22e9001b
parent0be6e5d71baee9dfa8165c3404c3be7e29682d53
EDAC/dmc520: Don't print an error for each unconfigured interrupt line

The dmc520 driver requires that at least one interrupt line, out of the
ten possible, is configured. The driver prints an error and returns
-EINVAL from its .probe function if there are no interrupt lines
configured.

Don't print a KERN_ERR level message for each interrupt line that's
unconfigured as that can confuse users into thinking that there is an
error condition.

Before this change, the following KERN_ERR level messages would be
reported if only dram_ecc_errc and dram_ecc_errd were configured in the
device tree:

  dmc520 68000000.dmc: IRQ ram_ecc_errc not found
  dmc520 68000000.dmc: IRQ ram_ecc_errd not found
  dmc520 68000000.dmc: IRQ failed_access not found
  dmc520 68000000.dmc: IRQ failed_prog not found
  dmc520 68000000.dmc: IRQ link_err not
  dmc520 68000000.dmc: IRQ temperature_event not found
  dmc520 68000000.dmc: IRQ arch_fsm not found
  dmc520 68000000.dmc: IRQ phy_request not found

Fixes: 9a8a702c3cd8 ("EDAC: Add EDAC driver for DMC520")
Reported-by: Sinan Kaya <okaya@kernel.org>
Signed-off-by: Tyler Hicks <tyhicks@linux.microsoft.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Link: https://lore.kernel.org/r/20220111163800.22362-1-tyhicks@linux.microsoft.com
drivers/edac/dmc520_edac.c