]> git.baikalelectronics.ru Git - kernel.git/commit
perf top: Do not use overwrite mode by default
authorArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 29 Oct 2018 12:47:00 +0000 (09:47 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Wed, 31 Oct 2018 12:57:31 +0000 (09:57 -0300)
commitb810d4f1d7a6b0f562506d71d237fd6a1d7e4340
tree594ef38e29a1410cf63e3b5c30f5e5bc74030ada
parentdb09f05d4bc63ba3d64735ed8623598ddb09f9d7
perf top: Do not use overwrite mode by default

Enabling --overwrite mode allows us to to use just the most recent
records, which helps in high core count machines such as Knights
Landing/Mill, but right now is being disabled by default as the pausing
used in this technique is leading to loss of metadata events such as
PERF_RECORD_MMAP which makes 'perf top' unable to resolve samples,
leading to lots of unknown samples appearing on the UI.

Enabling this may be useful if you are in such machines and profiling a
workload that doesn't creates short lived threads and/or doesn't uses
many executable mmap operations.

Work is being planed to solve this situation, till then, this will
remain disabled by default.

Reported-by: David Miller <davem@davemloft.net>
Acked-by: Kan Liang <kan.liang@intel.com>
Link: https://lkml.kernel.org/r/4f84468f-37d9-cf1b-12c1-514ef74b6a48@linux.intel.com
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Fixes: 17f2c540acec ("perf top: Switch default mode to overwrite mode")
Link: https://lkml.kernel.org/n/tip-ehvf77vi1si9409r7p4wx788@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/Documentation/perf-top.txt
tools/perf/builtin-top.c