]> git.baikalelectronics.ru Git - kernel.git/commit
AMD_SFH: Fix for incorrect Sensor index
authorSandeep Singh <sandeep.singh@amd.com>
Wed, 28 Oct 2020 09:00:10 +0000 (14:30 +0530)
committerJiri Kosina <jkosina@suse.cz>
Thu, 29 Oct 2020 15:02:29 +0000 (16:02 +0100)
commitb7f9e23de03b110d141eb57f2eec25c85d0262af
treeb9c342ed546ae52b4a9040e2d0820bfc49bf67cf
parent683c70f5455115168ada77c96f24fbcde8270c0c
AMD_SFH: Fix for incorrect Sensor index

It appears like the accelerometer/magnetometer and gyroscope indices were
interchanged in the patch series which got into for-5.11/amd-sfh-hid until
Mandoli/Richard reported to us.  Ideally sensor indices should be 0,1,2 for the
accelerometer, Gyroscope, Magnetometer respectively, but this interchanged
possibly could be because i was using a test MP2 firmware on my machine.

This patch fixes the earlier commit with the right sensor indices and also
removing unused structures _hid_report_descriptor, _hid_device_descriptor as
reported by Richard.

Fixes: 0bb5450b3c9c ("SFH: PCIe driver to add support of AMD sensor fusion hub 0bb5450b3c9c")
Reported-by: Mandoli <lipheng@hanmail.net>
Reported-by: Richard Neumann <mail@richard-neumann.de>
Signed-off-by: Sandeep Singh <sandeep.singh@amd.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
drivers/hid/amd-sfh-hid/hid_descriptor/amd_sfh_hid_desc.h