]> git.baikalelectronics.ru Git - kernel.git/commit
bnxt: remove ndo_poll_controller
authorEric Dumazet <edumazet@google.com>
Fri, 21 Sep 2018 22:27:50 +0000 (15:27 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 24 Sep 2018 04:55:25 +0000 (21:55 -0700)
commitb7e427cebf0f1db392fe035335692163f7021eb6
treec960462ac01e40179a1d6ad77e4f1b8734785d2e
parent0639a9fa713a0d1dd030632a0defc2c5291a8bf5
bnxt: remove ndo_poll_controller

As diagnosed by Song Liu, ndo_poll_controller() can
be very dangerous on loaded hosts, since the cpu
calling ndo_poll_controller() might steal all NAPI
contexts (for all RX/TX queues of the NIC). This capture
can last for unlimited amount of time, since one
cpu is generally not able to drain all the queues under load.

bnxt uses NAPI for TX completions, so we better let core
networking stack call the napi->poll() to avoid the capture.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnxt/bnxt.c