]> git.baikalelectronics.ru Git - kernel.git/commit
macb: fix PHY reset
authorSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Tue, 22 Mar 2016 19:27:38 +0000 (22:27 +0300)
committerDavid S. Miller <davem@davemloft.net>
Tue, 22 Mar 2016 20:07:07 +0000 (16:07 -0400)
commitb7cccc58ccb9a3671ab27561726883f2c24d78bc
tree2b4c2225e9d9b853033a17708bad40433902c69f
parenta96ac786b6981d936d6d83184ee3467b73a95ecf
macb: fix PHY reset

The driver calls gpiod_set_value() with GPIOD_OUT_* instead of 0 and 1, as
a result the PHY isn't really  put back into reset state in macb_remove().
Moreover, the driver assumes that something else has set the GPIO direction
to output, so if  it has not, the PHY may not be taken out of reset in
macb_probe() either...

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/cadence/macb.c