]> git.baikalelectronics.ru Git - kernel.git/commit
thinkpad-acpi: fix detection of old ThinkPads
authorHenrique de Moraes Holschuh <hmh@hmh.eng.br>
Tue, 17 Nov 2009 22:07:22 +0000 (14:07 -0800)
committerLen Brown <len.brown@intel.com>
Wed, 25 Nov 2009 05:42:15 +0000 (00:42 -0500)
commitb7c697772e77ca41a5b3e36c6207aa655bf817f3
treea61ea0213670f4b04435f881d5c61db5d5bfc1dc
parent4934940b7a7d6a32dfaf56b77e0d9d09924df84e
thinkpad-acpi: fix detection of old ThinkPads

There is a problem in the quirk tables used by tpacpi_is_fw_known() and
tpacpi_check_outdated_fw(), which causes outdated BIOSes that are lacking
the EC firmware ID DMI field to never match.

This breaks module loading on, e.g.  a T23 with outdated BIOS, and the
module will refuse to load unless the "force_load=1" parameter is given.

Fix the quirk tables so that they can also match the outdated BIOSes,
which in turn will both fix the module loading, and also warn the user
that he is using outdated firmware and should upgrade.

This fixes a serious regression, introduced by commit
2dace82a7f037c5992a136ec7a434992684adb50, "thinkpad-acpi: be more strict
when detecting a ThinkPad".

http://bugzilla.kernel.org/show_bug.cgi?id=14597

Reported-by: Paul Kimoto <kimoto@lightlink.com>
Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Tested-by: Paul Kimoto <kimoto@lightlink.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Len Brown <len.brown@intel.com>
drivers/platform/x86/thinkpad_acpi.c