]> git.baikalelectronics.ru Git - kernel.git/commit
hwmon: (ibmpex) Fix possible UAF when ibmpex_register_bmc() fails
authorGaosheng Cui <cuigaosheng1@huawei.com>
Thu, 17 Nov 2022 03:44:23 +0000 (11:44 +0800)
committerGuenter Roeck <linux@roeck-us.net>
Sun, 20 Nov 2022 14:04:16 +0000 (06:04 -0800)
commitb756fe98e7a3daf2c8ab6dd15d81e3268ac2dd7f
treecfe97d900185692d0ee9c1fae853a0f43a0f206c
parent915864543b6152c25400d794a2cee53d156f5249
hwmon: (ibmpex) Fix possible UAF when ibmpex_register_bmc() fails

Smatch report warning as follows:

drivers/hwmon/ibmpex.c:509 ibmpex_register_bmc() warn:
  '&data->list' not removed from list

If ibmpex_find_sensors() fails in ibmpex_register_bmc(), data will
be freed, but data->list will not be removed from driver_data.bmc_data,
then list traversal may cause UAF.

Fix by removeing it from driver_data.bmc_data before free().

Fixes: d9d2cfc8f864 ("hwmon: IBM power meter driver")
Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
Link: https://lore.kernel.org/r/20221117034423.2935739-1-cuigaosheng1@huawei.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/ibmpex.c