]> git.baikalelectronics.ru Git - kernel.git/commit
auxdisplay: lcd2s: Use proper API to free the instance of charlcd object
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Wed, 23 Feb 2022 15:47:18 +0000 (17:47 +0200)
committerMiguel Ojeda <ojeda@kernel.org>
Wed, 2 Mar 2022 23:30:31 +0000 (00:30 +0100)
commitb72b55a41243f99e91b87c5b30beeefaa563268d
tree58387ee9ec6cf300bcac857aa2820ebd827ade8a
parentef1e7af3abd2cb4db6717a96567f54670132c264
auxdisplay: lcd2s: Use proper API to free the instance of charlcd object

While it might work, the current approach is fragile in a few ways:
- whenever members in the structure are shuffled, the pointer will be wrong
- the resource freeing may include more than covered by kfree()

Fix this by using charlcd_free() call instead of kfree().

Fixes: 660c546809c3 ("auxdisplay: add a driver for lcd2s character display")
Cc: Lars Poeschel <poeschel@lemonage.de>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
drivers/auxdisplay/lcd2s.c