]> git.baikalelectronics.ru Git - kernel.git/commit
net: ethernet: ezchip: fix error handling
authorPavel Skripkin <paskripkin@gmail.com>
Fri, 18 Jun 2021 16:14:47 +0000 (19:14 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Jul 2021 14:53:30 +0000 (16:53 +0200)
commitb6d351f965faab7eea6da9e5c30fc833ff4805dd
tree17a0307332d2e0e9fc0feae4980f18a2b1a61e5d
parent4276ddc302e7b6f9f28e7baba145ea9813b9f60e
net: ethernet: ezchip: fix error handling

[ Upstream commit 0de449d599594f5472e00267d651615c7f2c6c1d ]

As documented at drivers/base/platform.c for platform_get_irq:

 * Gets an IRQ for a platform device and prints an error message if finding the
 * IRQ fails. Device drivers should check the return value for errors so as to
 * not pass a negative integer value to the request_irq() APIs.

So, the driver should check that platform_get_irq() return value
is _negative_, not that it's equal to zero, because -ENXIO (return
value from request_irq() if irq was not found) will
pass this check and it leads to passing negative irq to request_irq()

Fixes: 95c56cc33779 ("NET: Add ezchip ethernet driver")
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/ezchip/nps_enet.c