]> git.baikalelectronics.ru Git - kernel.git/commit
net: add a comment on netdev->last_rx
authorEric Dumazet <eric.dumazet@gmail.com>
Tue, 31 Aug 2010 07:40:16 +0000 (07:40 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 31 Aug 2010 20:37:06 +0000 (13:37 -0700)
commitb69c6c017075d168528d83ceeffcee2b25ee7c2c
tree7629fa72b5a13cbf48d43659bb396984caf7362a
parentc243b1c1f14d52613bd6b130161cfee69fac0c88
net: add a comment on netdev->last_rx

As some driver authors seem to reintroduce dev->last_rx use,
add a comment to strongly discourage this.

Since commit 6192d8054d2 (bonding, net: Move last_rx update into bonding
recv logic), network drivers dont need to update last_rx themselves,
unless they use this field to implement a timeout.

Not updating last_rx helps not dirtying a cache line, improving
performance in SMP.

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/linux/netdevice.h