]> git.baikalelectronics.ru Git - kernel.git/commit
libata: fix spurious WARN_ON_ONCE() on port freeze
authorTejun Heo <tj@kernel.org>
Thu, 17 Sep 2009 09:45:27 +0000 (18:45 +0900)
committerJeff Garzik <jgarzik@redhat.com>
Thu, 17 Sep 2009 20:45:40 +0000 (16:45 -0400)
commitb63351b7b1b0fb44c3e0a945a4e11e3d5d7fe783
tree2a7bab5698c431eae473e8df4a7b6ab10af27566
parent5d36e56fb934c435ab49a57b62512bf44930a63c
libata: fix spurious WARN_ON_ONCE() on port freeze

Commit 862fc2c226ce478334c0b2697eef16e564c39f4c makes libata abort qcs
after the port is frozen.  This is necessary to guarantee that TF
registers are accessed after the DMA engine is shutdown after an
error.  However, this triggers WARN_ON_ONCE() check in
ata_qc_complete() spuriously.  Move WARN_ON_ONCE() downwards such that
failing commands while frozen doesn't trigger it.

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: stable <stable@kernel.org>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
drivers/ata/libata-core.c