]> git.baikalelectronics.ru Git - kernel.git/commit
drm: Fix getconnector connection_mutex locking
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 5 Jun 2014 09:07:20 +0000 (11:07 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 5 Jun 2014 14:10:20 +0000 (16:10 +0200)
commitb615b5e470636bd49beb511f2379cc7aab8c85a3
tree295a58a2583fa37acea0d56f9ae0cbd15e44754d
parentf61f50e4ad1f29f6e0e31a2c7d7417d30a65decd
drm: Fix getconnector connection_mutex locking

I've fumbled my own idea and enthusiastically wrapped all the
getconnector code with the connection_mutex. But we only need it to
chase the connector->encoder link. Even there it's not really needed
since races with userspace won't matter, but better paranoid and
consistent about this stuff.

If we grap it everywhere connector probe callbacks can't grab it
themselves, which means they'll deadlock. i915 does that for the load
detect pipe. Furthermore i915 needs to do a ww dance since we also
need to grab the mutex of the load detect crtc.

This is a regression from

commit 1a3c3970134ccf90cc7c2d18795f0c17f25fe7d3
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Thu May 29 23:54:47 2014 +0200

    drm: Split connection_mutex out of mode_config.mutex (v3)

Cc: Rob Clark <robdclark@gmail.com>
Cc: Dave Airlie <airlied@redhat.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Rob Clark <robdclark@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/drm_crtc.c