]> git.baikalelectronics.ru Git - kernel.git/commit
of/unittest: add missing of_node_put
authorJulia Lawall <Julia.Lawall@lip6.fr>
Thu, 22 Oct 2015 09:02:50 +0000 (11:02 +0200)
committerRob Herring <robh@kernel.org>
Thu, 22 Oct 2015 14:26:28 +0000 (09:26 -0500)
commitb5f4371a93c5aa14f89576d427704e8791d4d7a8
tree5a0be890d65d0e5aabbaaa289f5a1e8fbcfec5ca
parent3fde49228b943cbbc3582f6e8506b30a25319c10
of/unittest: add missing of_node_put

for_each_child_of_node performs an of_node_get on each iteration, so
a break out of the loop requires an of_node_put.

A simplified version of the semantic patch that fixes this problem is as
follows (http://coccinelle.lip6.fr):

// <smpl>
@@
expression root,e;
local idexpression child;
@@

 for_each_child_of_node(root, child) {
   ... when != of_node_put(child)
       when != e = child
(
   return child;
|
+  of_node_put(child);
?  return ...;
)
   ...
 }
// </smpl>

Combine the puts into code at the end of the function, for conciseness.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Rob Herring <robh@kernel.org>
drivers/of/unittest.c