]> git.baikalelectronics.ru Git - kernel.git/commit
sched: etf: Fix ordering of packets with same txtime
authorVinicius Costa Gomes <vinicius.gomes@intel.com>
Mon, 14 Oct 2019 20:38:22 +0000 (13:38 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 16 Oct 2019 03:32:04 +0000 (20:32 -0700)
commitb5f1a485364146d9708369bdd32f2798fc0a361d
treeed91b53474128aef1288f49dda4a4ce8bf7e249a
parent2f462876ca00028fb478f6868a01c58f7da30a78
sched: etf: Fix ordering of packets with same txtime

When a application sends many packets with the same txtime, they may
be transmitted out of order (different from the order in which they
were enqueued).

This happens because when inserting elements into the tree, when the
txtime of two packets are the same, the new packet is inserted at the
left side of the tree, causing the reordering. The only effect of this
change should be that packets with the same txtime will be transmitted
in the order they are enqueued.

The application in question (the AVTP GStreamer plugin, still in
development) is sending video traffic, in which each video frame have
a single presentation time, the problem is that when packetizing,
multiple packets end up with the same txtime.

The receiving side was rejecting packets because they were being
received out of order.

Fixes: f37467d6ed91 ("net/sched: Introduce the ETF Qdisc")
Reported-by: Ederson de Souza <ederson.desouza@intel.com>
Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/sch_etf.c