]> git.baikalelectronics.ru Git - kernel.git/commit
mellanox: mlx5: avoid uninitialized variable warning with gcc-12
authorLinus Torvalds <torvalds@linux-foundation.org>
Thu, 9 Jun 2022 17:03:28 +0000 (10:03 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 9 Jun 2022 17:03:28 +0000 (10:03 -0700)
commitb5ea1b8ce2c168943fa4852d07db8ecddf7929ba
treeb799b2ed574a7bd685e3e991116157eadb3f99b1
parenta4746b062d4fc56887314a9531a80cb0d549193d
mellanox: mlx5: avoid uninitialized variable warning with gcc-12

gcc-12 started warning about 'tracker' being used uninitialized:

  drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c: In function ‘mlx5_do_bond’:
  drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c:786:28: warning: ‘tracker’ is used uninitialized [-Wuninitialized]
    786 |         struct lag_tracker tracker;
        |                            ^~~~~~~

which seems to be because it doesn't track how the use (and
initialization) is bound by the 'do_bond' flag.

But admittedly that 'do_bond' usage is fairly complicated, and involves
passing it around as an argument to helper functions, so it's somewhat
understandable that gcc doesn't see how that all works.

This function could be rewritten to make the use of that tracker
variable more obviously safe, but for now I'm just adding the forced
initialization of it.

Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c